Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'Courier New' on iOS #4267

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

craftzdog
Copy link

@craftzdog craftzdog commented Nov 3, 2021

Summary

The Courier font was removed in iOS 15. 'Courier New' is available since iPhone OS 3.

Changelog

  • [iOS] [Fixed] - Use 'Courier New' font in Code and Kbd components

Test Plan

import { Code } from 'native-base'

<Code>App.tsx</Code>

Workaround

Currently, you have to specify font family like so:

<Code _text={{ fontFamily: 'Courier New' }}>App.tsx</Code>

The Courier font was removed in iOS 15.
Fix other components
@vercel
Copy link

vercel bot commented Nov 3, 2021

@craftzdog is attempting to deploy a commit to the Geekyants Team Team on Vercel.

A member of the Team first needs to authorize it.

@craftzdog craftzdog changed the title Fix font Use 'Courier New' on iOS Nov 3, 2021
@stdavis
Copy link

stdavis commented Nov 24, 2021

I just ran expo init my-app --template expo-template-native-base and received this error when running the app:

fontFamily "Courier" is not a system font and has not been loaded through Font.loadAsync.

I'm running iOS 15. This PR seems as if it would solve this issue. Thanks!

@craftzdog
Copy link
Author

why closed? :(

@masafumimori
Copy link

masafumimori commented Jan 5, 2022

Just for people like me who encounter the same issue after running expo init my-app --template expo-template-native-base as @stdavis mentioned, directly modify index files in "node_modules/native-base/src/**" like in this PR.

This shouldn't be the best but It shuts up errors in terminals and it helps me not being annoyed by the error til this PR is opened and merged.
(keep in mind when you update packages, your modifycation will be removed or maybe this modification doen't do anything)

Hopefully this PR will be open and merged soon!

@stdavis
Copy link

stdavis commented Jan 5, 2022

https://www.npmjs.com/package/patch-package solves the issue of your changes being overwritten when you update your npm packages.

@surajahmed surajahmed reopened this Jan 14, 2022
@lilsharu
Copy link

lilsharu commented Feb 8, 2022

Is there any update on the status of this PR?

@TheyCodeMeSilvers
Copy link

Some handy shell scripts while we wait for the PR to be merged

sed -i -e 's/Courier/Courier New/' ./node_modules/native-base/src/components/composites/Code/index.tsx
sed -i -e 's/Courier/Courier New/' ./node_modules/native-base/src/theme/components/code.ts
sed -i -e 's/Courier/Courier New/' ./node_modules/native-base/src/theme/components/kbd.ts

@stale
Copy link

stale bot commented May 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 30, 2022
@stdavis
Copy link

stdavis commented May 31, 2022

It would be great if this PR was merged. Is there anything that I can do to help?

@stale stale bot removed the stale label May 31, 2022
@stale
Copy link

stale bot commented Jul 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants